Repository navigation
Conversation
palas
requested review from
Jimbo4350,
carbolymer,
disassembler and
kevinhammond
as code owners
November 12, 2026 18:30
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The BLS regression test defaults to text-envelope output, leaving the new Bech32 decoder path without round-trip coverage.
1 open issue
What changed in this PR
Addresses #1501 by extending the shared signing-key handling so key verification-key accepts BLS signing keys.
Changes:
- Adds BLS support to text-envelope and Bech32 signing-key readers.
- Generalizes the verification-key test helper and adds a BLS text-envelope round-trip test.
- Adds a changelog entry documenting the supported input formats.
| File | Description |
|---|---|
cardano-cli/test/cardano-cli-test/Test/Cli/VerificationKey.hs |
Generalizes key-generation commands and adds the BLS regression test. |
cardano-cli/src/Cardano/CLI/Type/Key.hs |
Adds BLS signing-key handling and decoders for both formats. |
.changes/20261111_162405_cardano-cli_pablo.lamela_bls_verification_key.yml |
Documents BLS verification-key derivation support. |
Review effort: Balanced
| , FromSomeType (AsSigningKey AsStakePoolExtendedKey) AStakePoolExtendedSigningKey | ||
| , FromSomeType (AsSigningKey AsVrfKey) AVrfSigningKey | ||
| , FromSomeType (AsSigningKey AsKesKey) AKesSigningKey | ||
| , FromSomeType (AsSigningKey AsBlsKey) ABlsSigningKey |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses: #1501
key verification-keycommand was not accepting BLS signing keys.This PR adds support for BLS signing keys to several functions that take signing keys
How to trust this PR
It is essentially extrapolation, except for tests, which now also apply to the
dijkstra node key-gen-BLScommand.Checklist
.changes/